nsivabalan commented on code in PR #13670:
URL: https://github.com/apache/hudi/pull/13670#discussion_r2250387786


##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/InputSplit.java:
##########
@@ -37,27 +41,30 @@
 public class InputSplit {
   private final Option<HoodieBaseFile> baseFileOption;
   private final List<HoodieLogFile> logFiles;
+  private final Option<Iterator<Pair<Serializable, BufferedRecord>>> 
recordIterator;

Review Comment:
   Cur code seems more clean to me. Prefer to leave it as is. 
   The constructor seems tight where only one of log files or record iterator 
can be instantiated. internally we can keep them separate. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to