yihua commented on code in PR #13670:
URL: https://github.com/apache/hudi/pull/13670#discussion_r2250423524
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/buffer/TestKeyBasedFileGroupRecordBuffer.java:
##########
@@ -146,11 +151,54 @@ void readWithEventTimeOrderingAndDeleteBlock() throws
IOException {
assertEquals(2, readStats.getNumUpdates());
}
+ @Test
+ void readWithEventTimeOrderingWithRecords() throws IOException {
Review Comment:
The reason I asked is because the following lines in
`StreamingFileGroupRecordBufferLoader#getRecordBuffer` are not covered by the
tests
```
while (recordIterator.hasNext()) {
Pair<Serializable, BufferedRecord> entry = recordIterator.next();
try {
recordBuffer.processNextDataRecord(entry.getValue(), entry.getKey());
} catch (IOException e) {
throw new HoodieIOException("Failed to process next toBeMergedRecord
", e);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
