rahil-c commented on code in PR #13642:
URL: https://github.com/apache/hudi/pull/13642#discussion_r2250660876
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/upgrade/TestUpgradeDowngrade.java:
##########
@@ -394,6 +395,115 @@ public void
testUpgradeFourtoFiveWithHiveStyleDefaultPartitionWithSkipValidation
testUpgradeFourToFiveInternal(true, true, true);
}
+ @Test
+ public void testUpgradeFourToFiveWithMetadataTableFailure() throws Exception
{
Review Comment:
Currently without any of my changes, the pattern within that test class
[TestUpgradeDowngrade](https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/upgrade/TestUpgradeDowngrade.java#L428)
today is a litte messy.
For instance, the write config usually is constructed for each tests using
the hoodie.table.verison as 6 as seen
[here](https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/upgrade/TestUpgradeDowngrade.java#L460).
The problem is that if you want to test older paths say tables on v4 or
v5, you basically have to downgrade the table version as seen with this
[method](https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/upgrade/TestUpgradeDowngrade.java#L428)
`downgradeTableConfigsFromFiveToFour` .
@yihua mentioned to me to create a new approach for testing
upgrade/downgrade, ideally hoping the fixtures pr
https://github.com/apache/hudi/pull/13669 is more cleaner to you and avoids the
current setup issues of the existing approach in the current
`TestUpgradeDowngrade `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
