danny0405 commented on code in PR #13600:
URL: https://github.com/apache/hudi/pull/13600#discussion_r2252826549
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecordMergerFactory.java:
##########
@@ -394,30 +407,36 @@ public MergeResult<T>
mergeNonDeleteRecord(BufferedRecord<T> olderRecord, Buffer
* based on {@code CUSTOM} merge mode and a given record payload class.
*/
private static class CustomPayloadRecordMerger<T> extends
BaseCustomMerger<T> {
- private final List<String> orderingFieldNames;
- private final String payloadClass;
+ private final String[] orderingFieldNames;
+ private final String basePayloadClass;
+ private final String incomingPayloadClass;
Review Comment:
> A second implementation would only differ by how we construct the payloads
so I am not sure if it is worth a new class.
Let's try to add a new merger and doc it that it's for MIT expression
payload, you can add some override method to the existing one like
`getDeltaMergePayload()`, `getFinalMergePayload`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
