danny0405 commented on code in PR #13615:
URL: https://github.com/apache/hudi/pull/13615#discussion_r2253021658
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCreateRecordUtils.scala:
##########
@@ -143,19 +143,24 @@ object HoodieCreateRecordUtils {
avroRecWithoutMeta
}
- val hoodieRecord = if (shouldCombine && !precombineFields.isEmpty)
{
- val orderingVal = OrderingValues.create(
- precombineFields,
- JFunction.toJavaFunction[String, Comparable[_]](
- field => HoodieAvroUtils.getNestedFieldVal(avroRec, field,
false,
-
consistentLogicalTimestampEnabled).asInstanceOf[Comparable[_]]))
- DataSourceUtils.createHoodieRecord(processedRecord, orderingVal,
hoodieKey,
- config.getPayloadClass, recordLocation)
+ val payloadClass = config.getPayloadClass
+ if (StringUtils.isNullOrEmpty(payloadClass)) {
+ DataSourceUtils.createHoodieRecord(processedRecord, hoodieKey,
recordLocation)
Review Comment:
we can not use this, record would contain a schema schema field which is
huge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]