danny0405 commented on code in PR #13600:
URL: https://github.com/apache/hudi/pull/13600#discussion_r2253905776
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecordMergerFactory.java:
##########
@@ -95,14 +95,11 @@ public static <T> BufferedRecordMerger<T>
create(HoodieReaderContext<T> readerCo
return new
EventTimePartiaRecordMerger<>(readerContext.getRecordContext(),
partialUpdateMode, props);
default:
if (payloadClasses.isPresent()) {
- if
(payloadClasses.get().getLeft().equals(payloadClasses.get().getRight())) {
- return new
CustomPayloadRecordMerger<>(readerContext.getRecordContext(), recordMerger,
orderingFieldNames, payloadClasses.get().getLeft(), readerSchema, props);
- } else {
- // The payload classes can only be different when the expression
payload is used with a Merge-Into operation.
-
ValidationUtils.checkArgument(payloadClasses.get().getRight().contains("ExpressionPayload"),
- "The payload class for the new record must be
ExpressionPayload when specifying two separate payload classes in the merger.");
+ if
(payloadClasses.get().getRight().equals("org.apache.spark.sql.hudi.command.payload.ExpressionPayload"))
{
Review Comment:
@lokeshj1703 can you fire a JIRA task to fix the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
