rahil-c commented on code in PR #13642:
URL: https://github.com/apache/hudi/pull/13642#discussion_r2254805369
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java:
##########
@@ -144,23 +178,18 @@ public void run(HoodieTableVersion toVersion, String
instantTime) {
.run(toVersion, instantTime);
}
} catch (Exception e) {
- LOG.warn("Unable to upgrade or downgrade the metadata table to version
" + toVersion
- + ", ignoring the error and continue.", e);
+ throw new HoodieUpgradeDowngradeException("Upgrade/downgrade for the
Hudi metadata table failed. "
+ + "Please try again. If the failure repeats for metadata table, it
is recommended to disable "
+ + "the metadata table so that the upgrade and downgrade can
continue for the data table.", e);
Review Comment:
I am not sure on this specific case for all upgrade/downgrade paths. However
I do not think in certain handlers it would allow the old version of the MDT to
exist, when looking for example at this handler it seems we ensure to delete
the mdt table if it is lagging behind in version from data table.
https://github.com/apache/hudi/blob/master/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/SevenToEightUpgradeHandler.java#L99
@nsivabalan @yihua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
