linliu-code commented on code in PR #13656:
URL: https://github.com/apache/hudi/pull/13656#discussion_r2254806807
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -2038,4 +2098,24 @@ object TestCOWDataSource {
df.withColumn(c, when(col(c).isNotNull, col(c)).otherwise(lit(null)))
}
}
+
+ def provideParamsForKeyGenTest(): java.util.List[Arguments] = {
+ java.util.Arrays.asList(
+ Arguments.of(
+ "org.apache.hudi.keygen.MockUserProvidedKeyGenerator",
+ KeyGeneratorType.USER_PROVIDED.name()),
+ Arguments.of(
+ "",
Review Comment:
> isnt' the 2nd case here expected to fail? i.e. setting type to
`USER_PROVIDED`, but not setting any class.
Yes, it failed, and it catches Line 2054.
> Also, where is the other test I asked for, i.e. setting the `class`, but
not explicitly setting the `type`
Line 21117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
