danny0405 commented on code in PR #13679:
URL: https://github.com/apache/hudi/pull/13679#discussion_r2255680833
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/UpdateProcessor.java:
##########
@@ -100,7 +100,7 @@ public T processUpdate(String recordKey, T previousRecord,
T currentRecord, bool
if (isDelete) {
callback.onDelete(recordKey, previousRecord);
- } else if (previousRecord != null && previousRecord != currentRecord) {
+ } else if (previousRecord != null && currentRecord != null) {
Review Comment:
This seems not right, currentRecord can only be null when this is a delete,
but delete is already handled preceedingly. The original logic is correct cc
@the-other-tim-brown for double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
