yihua commented on code in PR #13493: URL: https://github.com/apache/hudi/pull/13493#discussion_r2258451495
########## hudi-trino-plugin/.mvn/modernizer/violations-production-code-only.xml: ########## @@ -0,0 +1,68 @@ +<?xml version="1.0"?> +<modernizer> + <violation> Review Comment: Are these violations coming from the code in `hudi-trino-plugin`? If so, why is the build fine in the Trino repo (is it because of the additional rules in the root POM of Trino)? ########## hudi-trino-plugin/.mvn/modernizer/violations.xml: ########## @@ -0,0 +1,347 @@ +<?xml version="1.0"?> Review Comment: I see. These are copied from `.mvn/modernizer` folder in Trino repo to suppress violations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
