the-other-tim-brown commented on code in PR #13679:
URL: https://github.com/apache/hudi/pull/13679#discussion_r2261687213
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedMergeHandle.java:
##########
@@ -75,13 +90,56 @@
public class FileGroupReaderBasedMergeHandle<T, I, K, O> extends
HoodieWriteMergeHandle<T, I, K, O> {
private static final Logger LOG =
LoggerFactory.getLogger(FileGroupReaderBasedMergeHandle.class);
- private final HoodieReaderContext<T> readerContext;
- private final CompactionOperation operation;
+ private final Option<CompactionOperation> operation;
private final String maxInstantTime;
+ private HoodieReaderContext<T> readerContext;
private HoodieReadStats readStats;
- private final HoodieRecord.HoodieRecordType recordType;
- private final Option<HoodieCDCLogger> cdcLogger;
+ private HoodieRecord.HoodieRecordType recordType;
+ private Option<HoodieCDCLogger> cdcLogger;
+ private Option<RecordLevelIndexCallback> recordIndexCallbackOpt;
+ private Option<SecondaryIndexCallback> secondaryIndexCallbackOpt;
+ private boolean usePosition;
+ private boolean isCompaction;
+ private final TypedProperties props;
+ private Iterator<BufferedRecord<T>> incomingRecordsItr;
+ public FileGroupReaderBasedMergeHandle(HoodieWriteConfig config, String
instantTime, HoodieTable<T, I, K, O> hoodieTable,
+ Iterator<HoodieRecord<T>> recordItr,
String partitionPath, String fileId,
+ TaskContextSupplier
taskContextSupplier, Option<BaseKeyGenerator> keyGeneratorOpt) {
+ super(config, instantTime, hoodieTable, recordItr, partitionPath, fileId,
taskContextSupplier, keyGeneratorOpt);
+ this.operation = Option.empty();
+ // to do: fix this to getReaderContextFactoryForWrite after we land the
dedup and global index path fix.
Review Comment:
I have a local branch with this and some other cleanup. Once
https://github.com/apache/hudi/pull/13688 is merged, there is a good amount of
cleanup that can happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
