rahil-c commented on code in PR #13687:
URL: https://github.com/apache/hudi/pull/13687#discussion_r2261932618
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java:
##########
@@ -95,6 +95,16 @@ public static boolean needsUpgrade(HoodieTableMetaClient
metaClient, HoodieWrite
throw new HoodieUpgradeDowngradeException(
String.format("Please upgrade table from version %s to %s before
upgrading to version %s.", fromTableVersion,
HoodieTableVersion.SIX.versionCode(), toWriteVersion));
}
+ // for table versions greater than or equal to six, if we are attempting
to do an upgrade and auto-upgrade is disabled
Review Comment:
Synced with Ethan offline, and agreed that in general we should try to align
the `toWriteVerson` is provided by `config.getWriteVersion`. For cli and
procedcure we will also ensure those code paths are aligned with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
