cshuo commented on code in PR #13696:
URL: https://github.com/apache/hudi/pull/13696#discussion_r2262726072
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/cdc/CdcInputFormat.java:
##########
@@ -333,29 +340,45 @@ static class DataLogFileIterator implements
ClosableIterator<RowData> {
private final long maxCompactionMemoryInBytes;
private final ImageManager imageManager;
private final RowDataProjection projection;
- private final HoodieRecordMerger recordMerger;
- private final TypedProperties payloadProps;
+ private final BufferedRecordMerger recordMerger;
private final ClosableIterator<HoodieRecord<RowData>> logRecordIterator;
private ExternalSpillableMap<String, byte[]> beforeImages;
private RowData currentImage;
private RowData sideImage;
+ private HoodieReaderContext<RowData> readerContext;
+ private String[] orderingFields;
+ private TypedProperties props;
DataLogFileIterator(
- Configuration flinkConf,
long maxCompactionMemoryInBytes,
ImageManager imageManager,
HoodieCDCFileSplit cdcFileSplit,
MergeOnReadTableState tableState,
- ClosableIterator<HoodieRecord<RowData>> logRecordIterator) throws
IOException {
+ ClosableIterator<HoodieRecord<RowData>> logRecordIterator,
+ HoodieTableMetaClient metaClient,
+ HoodieWriteConfig writeConfig,
+ Configuration flinkConf) throws IOException {
Review Comment:
`flinkConf` can be removed now.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/cdc/CdcInputFormat.java:
##########
@@ -333,29 +340,45 @@ static class DataLogFileIterator implements
ClosableIterator<RowData> {
private final long maxCompactionMemoryInBytes;
private final ImageManager imageManager;
private final RowDataProjection projection;
- private final HoodieRecordMerger recordMerger;
- private final TypedProperties payloadProps;
+ private final BufferedRecordMerger recordMerger;
private final ClosableIterator<HoodieRecord<RowData>> logRecordIterator;
private ExternalSpillableMap<String, byte[]> beforeImages;
private RowData currentImage;
private RowData sideImage;
+ private HoodieReaderContext<RowData> readerContext;
+ private String[] orderingFields;
+ private TypedProperties props;
DataLogFileIterator(
- Configuration flinkConf,
long maxCompactionMemoryInBytes,
ImageManager imageManager,
HoodieCDCFileSplit cdcFileSplit,
MergeOnReadTableState tableState,
- ClosableIterator<HoodieRecord<RowData>> logRecordIterator) throws
IOException {
+ ClosableIterator<HoodieRecord<RowData>> logRecordIterator,
+ HoodieTableMetaClient metaClient,
+ HoodieWriteConfig writeConfig,
Review Comment:
we can get write config from `imageManager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
