the-other-tim-brown commented on code in PR #13688:
URL: https://github.com/apache/hudi/pull/13688#discussion_r2263031393
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/UpdateProcessor.java:
##########
@@ -95,15 +108,15 @@ public CallbackProcessor(BaseFileUpdateCallback callback,
UpdateProcessor<T> del
}
@Override
- public T processUpdate(String recordKey, T previousRecord, T
currentRecord, boolean isDelete) {
- T result = delegate.processUpdate(recordKey, previousRecord,
currentRecord, isDelete);
+ public BufferedRecord<T> processUpdate(String recordKey, BufferedRecord<T>
previousRecord, BufferedRecord<T> mergedRecord, boolean isDelete) {
+ BufferedRecord<T> result = delegate.processUpdate(recordKey,
previousRecord, mergedRecord, isDelete);
if (isDelete) {
- callback.onDelete(recordKey, previousRecord);
- } else if (previousRecord != null && previousRecord != currentRecord) {
- callback.onUpdate(recordKey, previousRecord, currentRecord);
- } else {
- callback.onInsert(recordKey, currentRecord);
Review Comment:
Thanks for the update, I had to make a similar change in my patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
