wangxianghu commented on a change in pull request #2314:
URL: https://github.com/apache/hudi/pull/2314#discussion_r539328483
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/IncrementalRelation.scala
##########
@@ -92,17 +92,8 @@ class IncrementalRelation(val sqlContext: SQLContext,
StructType(skeletonSchema.fields ++ dataSchema.fields)
}
-
- private val filters = {
- if
(optParams.contains(DataSourceReadOptions.PUSH_DOWN_INCR_FILTERS_OPT_KEY)) {
Review comment:
> Why we remove the if/else block?
because if the map does contain
`DataSourceReadOptions.PUSH_DOWN_INCR_FILTERS_OPT_KEY`, we will set it to the
default value, and the default value will result in an empty array, same as the
else block. so there is no need to check it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
