danny0405 commented on code in PR #13714:
URL: https://github.com/apache/hudi/pull/13714#discussion_r2271858826
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupReaderSchemaHandler.java:
##########
@@ -124,6 +132,18 @@ public DeleteContext getDeleteContext() {
return deleteContext;
}
+ public Pair<Schema, Map<String, String>>
getRequiredSchemaForFileAndRenamedColumns(StoragePath path) {
+ if (internalSchema.isEmptySchema()) {
+ return Pair.of(requiredSchema, Collections.emptyMap());
+ }
+ long commitInstantTime =
Long.parseLong(FSUtils.getCommitTime(path.getName()));
+ InternalSchema fileSchema =
InternalSchemaCache.searchSchemaAndCache(commitInstantTime, metaClient);
Review Comment:
Looks like we already did this in
`FileGroupRecordBuffer.composeEvolvedSchemaTransformer`, and we have optimized
the logic in #13525 to get rid of the timeline listing, should be good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
