leesf commented on a change in pull request #2310:
URL: https://github.com/apache/hudi/pull/2310#discussion_r539388158



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackUtils.java
##########
@@ -114,7 +114,15 @@ static HoodieRollbackStat 
mergeRollbackStat(HoodieRollbackStat stat1, HoodieRoll
     HoodieWriteConfig config = table.getConfig();
     List<String> partitions = 
FSUtils.getAllPartitionPaths(table.getMetaClient().getFs(), 
table.getMetaClient().getBasePath(),
         config.shouldAssumeDatePartitioning());
-    int sparkPartitions = Math.max(Math.min(partitions.size(), 
config.getRollbackParallelism()), 1);
+    int partSize = partitions.size();
+    if (partitions.size() <= 0) {

Review comment:
       sorry, I am not fully understand in which case the partitions would be 
empty, does it mean non partitioned table? or would you please add some tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to