nsivabalan commented on code in PR #13519:
URL: https://github.com/apache/hudi/pull/13519#discussion_r2274940246
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -582,13 +591,18 @@ private static void deleteFile(HoodieStorage storage,
StoragePath cfgPath) throw
*/
public static void update(HoodieStorage storage, StoragePath metadataFolder,
Properties updatedProps) {
- modify(storage, metadataFolder, updatedProps,
ConfigUtils::upsertProperties);
+ modify(storage, metadataFolder, updatedProps,
ConfigUtils::upsertProperties, Collections.EMPTY_SET);
+ }
+
+ public static void updateDeleteProps(HoodieStorage storage, StoragePath
metadataFolder,
+ Properties updatedProps, Set<String>
propstoDelete) {
+ modify(storage, metadataFolder, updatedProps,
ConfigUtils::upsertProperties, propstoDelete);
}
public static void delete(HoodieStorage storage, StoragePath metadataFolder,
Set<String> deletedProps) {
Properties props = new Properties();
deletedProps.forEach(p -> props.setProperty(p, ""));
- modify(storage, metadataFolder, props, ConfigUtils::deleteProperties);
+ modify(storage, metadataFolder, props, ConfigUtils::deleteProperties,
Collections.EMPTY_SET);
Review Comment:
nope. we want to update hoodie.properties atomically. So, we can't really
update hoodie.properties once for `update` and once for `delete`. and hence we
had to take this route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
