danny0405 commented on code in PR #13718:
URL: https://github.com/apache/hudi/pull/13718#discussion_r2275050117
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -171,8 +171,9 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "Refer to org.apache.spark.storage.StorageLevel for different
values");
public static final ConfigProperty<String> PRECOMBINE_FIELD_NAME =
ConfigProperty
- .key("hoodie.datasource.write.precombine.field")
+ .key("hoodie.datasource.write.precombine.fields")
Review Comment:
should we just remove this write config option because it is never a write
config, we can check the old write config option when creating table the first
time. for all the other cases, we should read from the table config to get the
ordering fields instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
