danny0405 commented on code in PR #13615:
URL: https://github.com/apache/hudi/pull/13615#discussion_r2275638322
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala:
##########
@@ -227,9 +256,14 @@ object HoodieWriterUtils {
val diffConfigs = StringBuilder.newBuilder
params.foreach { case (key, value) =>
if (!shouldIgnoreConfig(key, value, params, tableConfig)) {
- val existingValue =
getStringFromTableConfigWithAlternatives(tableConfig, key)
+ val keyInTableConfig = if
(key.equals(HoodieTableConfig.PAYLOAD_CLASS_NAME.key)) {
Review Comment:
can just inline the check
`key.equals(HoodieTableConfig.PAYLOAD_CLASS_NAME.key)` into method
`getPayloadClassConfigKeyFromTableConfig`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
