the-other-tim-brown commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2277894821
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/io/TestMergeHandle.java:
##########
@@ -124,4 +159,390 @@ public void
testMergeHandleRLIAndSIStatsWithUpdatesAndDeletes() throws Exception
assertEquals(2 * numUpdates + numDeletes,
writeStatus.getIndexStats().getSecondaryIndexStats().values().stream().findFirst().get().size());
validateSecondaryIndexStatsContent(writeStatus, numUpdates, numDeletes);
}
+
+ @ParameterizedTest // TODO add CUSTOM_MERGER once deletes are handled
properly
+ @ValueSource(strings = {"EVENT_TIME_ORDERING", "COMMIT_TIME_ORDERING",
"CUSTOM"})
Review Comment:
See the TODO above, it will fail until we allow the custom merger to manage
its own deletes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
