nsivabalan commented on code in PR #13721:
URL: https://github.com/apache/hudi/pull/13721#discussion_r2279749006
##########
hudi-common/src/main/java/org/apache/hudi/common/table/PartialUpdateMode.java:
##########
@@ -26,23 +26,14 @@ public enum PartialUpdateMode {
"No partial update logic should be employed.")
NONE,
- @EnumFieldDescription(
- "For any column values missing in current record, pick value from
previous version of the record.")
- KEEP_VALUES,
-
- @EnumFieldDescription(
- "For column values missing in current record, pick the default value
from the schema.")
- FILL_DEFAULTS,
-
Review Comment:
those were just place holders and we did not have real use-cases for time
being.
In all, we just need 2 for time being.
and when we are looking to unify MIT partial encoding (to bring it within
PartialUpdateHandler), we might need `KEEP_VALUES'.
but as of this patch, we are keeping it simple and not unifying the impl
yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
