yanghua commented on a change in pull request #2319:
URL: https://github.com/apache/hudi/pull/2319#discussion_r540224339
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/SparkHoodieBloomIndex.java
##########
@@ -252,11 +252,9 @@ public boolean isImplicitWithStorage() {
* Make sure the parallelism is atleast the groupby parallelism for tagging
location
*/
JavaPairRDD<HoodieKey, HoodieRecordLocation> findMatchingFilesForRecordKeys(
- final Map<String, List<BloomIndexFileInfo>> partitionToFileIndexInfo,
- JavaPairRDD<String, String> partitionRecordKeyPairRDD, int
shuffleParallelism, HoodieTable hoodieTable,
+ JavaRDD<Tuple2<String, HoodieKey>> fileComparisonsRDD,
+ int shuffleParallelism, HoodieTable hoodieTable,
Review comment:
Maybe we can move `fileGroupToComparisons ` into this line or break the
`hoodieTable ` to the next line. It would be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
