nsivabalan commented on a change in pull request #2311: URL: https://github.com/apache/hudi/pull/2311#discussion_r540541958
########## File path: hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayloadV1.java ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.model; + +import static org.apache.hudi.avro.HoodieAvroUtils.bytesToAvro; +import static org.apache.hudi.avro.HoodieAvroUtils.getNestedFieldVal; + +import java.util.Collections; +import java.util.Map; +import org.apache.hudi.common.util.Option; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericRecord; +import org.apache.avro.generic.IndexedRecord; + +import java.io.IOException; + +/** + * Default payload used for delta streamer. + * <p> + * 1. preCombine - Picks the latest delta record for a key, based on an ordering field 2. + * combineAndGetUpdateValue/getInsertValue - Simply overwrites storage with latest delta record + */ +public class OverwriteWithLatestAvroPayloadV1 extends BaseAvroPayload + implements HoodieRecordPayload<OverwriteWithLatestAvroPayloadV1> { + + private Map<String, String> props; Review comment: yeah. lets wait to hear from @vinothchandar . Previous impl was sending in this map as arg to combineAndGetUpdateValue rather than storing it as instance var. may be thats better in terms of storage cost. I thought we could avoid making changes to all callers of combineAndGetUpdateValue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
