rahil-c opened a new pull request, #13737:
URL: https://github.com/apache/hudi/pull/13737

   ### Change Logs
   
   @linliu-code pointed out to me that the following additional tests cases in 
   
   ```
       "8,8,false,NO_UPGRADE", // Auto-upgrade disabled
       "8,8,true,NO_UPGRADE" // Auto-upgrade enabled
   ```
   
   
   `TestMORDataSource.testBaseHoodieWriteClientUpgradeDecisionLogic` were 
failing due to this
   
   
   
   
   ```
   Caused by: java.lang.NullPointerException: Expected a non-null value. Got 
null
        at org.apache.hudi.common.util.Option.<init>(Option.java:65)
        at org.apache.hudi.common.util.Option.of(Option.java:76)
        at 
org.apache.hudi.metadata.HoodieTableMetadataUtil.getIndexVersionOption(HoodieTableMetadataUtil.java:2794)
        at 
org.apache.hudi.metadata.HoodieTableMetadataUtil.existingIndexVersionOrDefault(HoodieTableMetadataUtil.java:2798)
        at 
org.apache.hudi.metadata.HoodieBackedTableMetadataWriter.getRecordTagger(HoodieBackedTableMetadataWriter.java:1837)
        at 
org.apache.hudi.metadata.HoodieBackedTableMetadataWriter.tagRecordsWithLocation(HoodieBackedTableMetadataWriter.java:1829)
        at 
org.apache.hudi.metadata.HoodieBackedTableMetadataWriter.prepareAndWriteToNonStreamingPartitions(HoodieBackedTableMetadataWriter.java:1308)
        at 
org.apache.hudi.metadata.HoodieBackedTableMetadataWriter.completeStreamingCommit(HoodieBackedTableMetadataWriter.java:1297)
        at 
org.apache.hudi.client.StreamingMetadataWriteHandler.commitToMetadataTable(StreamingMetadataWriteHandler.java:79)
        ... 68 more
   
   ```
   
   ### Impact
   
   No impact, since minor change to just add a NPE check.
   
   ### Risk level (write none, low medium or high below)
   
   none
   
   ### Documentation Update
   
   No doc update required 
   
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to