danny0405 commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2287265596
##########
hudi-common/src/main/java/org/apache/hudi/keygen/KeyGenerator.java:
##########
@@ -70,14 +70,8 @@ public List<String> getRecordKeyFieldNames() {
* @param recordValueFunction takes the record key field name and the index
of the field in the record key fields and outputs a value
* @return the record key
*/
+ // TODO(yihua): check all callers
Review Comment:
is the TODO addressed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
