danny0405 commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2290051453
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -126,12 +126,9 @@ protected RowDataKeyGen(
this.partitionPathProjection = null;
} else {
this.partitionPathProjection = getProjection(this.partitionPathFields,
fieldNames, fieldTypes);
- if (simpleRecordKey) {
- // single record key with multiple partition fields
- encodesSimpleRecordKeyWithFieldName =
isComplexKeygenEncodeSingleRecordKeyFieldName;
- }
}
if (simpleRecordKey) {
+ encodesSimpleRecordKeyWithFieldName =
isComplexKeygenEncodeSingleRecordKeyFieldName;
Review Comment:
this is not right, when partition fields is single, we should not encode the
pk with field name, that is how the simple key gen is doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
