cshuo commented on code in PR #13734:
URL: https://github.com/apache/hudi/pull/13734#discussion_r2289985779
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java:
##########
@@ -235,13 +236,16 @@ private void initRecordConverter() {
private void initMergeClass() {
readerContext =
writeClient.getEngineContext().<RowData>getReaderContextFactory(metaClient).getContext();
orderingFieldNames = getOrderingFieldNames(readerContext.getMergeMode(),
writeClient.getConfig().getProps(), metaClient);
+ // for table with lower versions, the merge mode in table config may be
null, use merge mode in write config then.
+ RecordMergeMode mergeMode =
metaClient.getTableConfig().getRecordMergeMode() == null
Review Comment:
need to infer merge mode correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
