danny0405 commented on code in PR #13734:
URL: https://github.com/apache/hudi/pull/13734#discussion_r2291019251
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java:
##########
@@ -249,6 +249,10 @@ public static HoodieWriteConfig getHoodieClientConfig(
.withRecordMergeMode(mergingBehavior.getLeft())
.withRecordMergeImplClasses(StreamerUtil.getMergerClasses(conf,
mergingBehavior.getLeft(), mergingBehavior.getMiddle()));
+ StreamerUtil.checkWriteMergeHandle(conf);
+ builder.withMergeHandleClassName(conf.getString(
+ HoodieWriteConfig.MERGE_HANDLE_CLASS_NAME.key(),
HoodieWriteConfig.MERGE_HANDLE_CLASS_NAME.defaultValue()));
Review Comment:
can we set the write handle correctly and log a warning log there instead of
throw exception, BTW, there is no need to set up the builder explciitly if the
option key comes from `HoodieWriteConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
