linliu-code commented on code in PR #13738:
URL: https://github.com/apache/hudi/pull/13738#discussion_r2292005810
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -276,10 +279,10 @@ private void initRecordMerger(TypedProperties properties,
boolean isIngestion) {
HoodieTableVersion tableVersion = tableConfig.getTableVersion();
// If the provided payload class differs from the table's payload class,
we need to infer the correct merging behavior.
if (isIngestion && writerPayloadClass.map(className ->
!className.equals(tableConfig.getPayloadClass())).orElse(false)) {
- Triple<RecordMergeMode, String, String> triple =
HoodieTableConfig.inferMergingConfigsForWrites(null, writerPayloadClass.get(),
null,
Review Comment:
For read branch below, v9 tables are supposed to have all merge properties
set properly at creation or during upgrade. So no inference should be attempted.
For this write branch, the merge properties can be overwritten by temporary
payload classes, merge mode or strategy id; therefore, we need to run the
inference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
