danny0405 commented on code in PR #13738:
URL: https://github.com/apache/hudi/pull/13738#discussion_r2292497399
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -162,6 +164,9 @@ protected HoodieTable(HoodieWriteConfig config,
HoodieEngineContext context, Hoo
this.viewManager = getViewManager();
this.metaClient = metaClient;
this.taskContextSupplier = context.getTaskContextSupplier();
+
+ // Extract necessary properties from table config to write config.
+ reconcileWriteConfigs(metaClient, config);
Review Comment:
should we fix the options in `HoodieIOHandle` instead of there, not sure
whether the write config in hoodie table is actually the write config we use
for write handles, we pass the write config separately for write handles
actually.
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -1883,7 +1883,7 @@ public void testPartialPayloadClass() throws Exception {
//now assert that hoodie.properties file now has updated payload class name
HoodieTableMetaClient metaClient = UtilHelpers.createMetaClient(jsc,
dataSetBasePath, false);
- assertEquals(metaClient.getTableConfig().getPayloadClass(),
PartialUpdateAvroPayload.class.getName());
+ assertEquals(metaClient.getTableConfig().getPayloadClass(),
DefaultHoodieRecordPayload.class.getName());
Review Comment:
not sure this is right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
