danny0405 commented on code in PR #13766:
URL: https://github.com/apache/hudi/pull/13766#discussion_r2299520501
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/RemoteHoodieTableFileSystemView.java:
##########
@@ -150,22 +154,53 @@ public RemoteHoodieTableFileSystemView(String server, int
port, HoodieTableMetaC
}
public RemoteHoodieTableFileSystemView(HoodieTableMetaClient metaClient,
FileSystemViewStorageConfig viewConf) {
+ this(metaClient, TimelineUtils.getVisibleTimelineForFsView(metaClient),
viewConf);
+ }
+
+ public RemoteHoodieTableFileSystemView(HoodieTableMetaClient metaClient,
HoodieTimeline timeline, FileSystemViewStorageConfig viewConf) {
+ this(metaClient, timeline, new TimelineServiceClient(viewConf), viewConf);
+ }
+
+ @VisibleForTesting
+ public RemoteHoodieTableFileSystemView(HoodieTableMetaClient metaClient,
HoodieTimeline timeline, TimelineServiceClient timelineServiceClient,
FileSystemViewStorageConfig viewConf) {
this.basePath = metaClient.getBasePath().toString();
this.metaClient = metaClient;
this.timeline =
metaClient.getActiveTimeline().filterCompletedAndCompactionInstants();
Review Comment:
`this.timeline` should be the same with the param `timeline`, should assign
directly to keep consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
