yihua commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2299552132
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/GlobalDeleteKeyGenerator.java:
##########
@@ -60,13 +60,13 @@ public String getPartitionPath(GenericRecord record) {
@Override
public String getRecordKey(Row row) {
tryInitRowAccessor(row.schema());
- return combineCompositeRecordKey(rowAccessor.getRecordKeyParts(row));
+ return combineCompositeRecordKey(true, rowAccessor.getRecordKeyParts(row));
Review Comment:
@danny0405 I see that the original implementation of
`GlobalDeleteKeyGenerator` does not take into account the number of record key
fields, unlike complex key gen. So the change here is to maintain parity as
before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
