nsivabalan commented on code in PR #13785:
URL: https://github.com/apache/hudi/pull/13785#discussion_r2306091991
##########
hudi-aws/src/main/java/org/apache/hudi/config/GlueCatalogSyncClientConfig.java:
##########
@@ -97,4 +103,36 @@ public class GlueCatalogSyncClientConfig extends
HoodieConfig {
.markAdvanced()
.withDocumentation("Glue sync may fail if the Glue table exists with
partitions differing from the Hoodie table or if schema evolution is not
supported by Glue."
+ "Enabling this configuration will drop and create the table to
match the Hoodie config");
+
+ public static final ConfigProperty<String> GLUE_CATALOG_ID = ConfigProperty
+ .key(GLUE_CLIENT_PROPERTY_PREFIX + "catalogId")
+ .noDefaultValue()
+ .sinceVersion("0.15.0")
Review Comment:
1.1.0
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -1128,4 +1163,35 @@ private static boolean
updateTableParameters(GlueAsyncClient awsGlue, String dat
throw new HoodieGlueSyncException("Fail to update params for table " +
tableId(databaseName, tableName) + ": " + updatingParams, e);
}
}
+
+ private String getBasePathForTable() {
Review Comment:
is this being used anywhere?
##########
hudi-aws/src/main/java/org/apache/hudi/config/GlueCatalogSyncClientConfig.java:
##########
@@ -97,4 +103,36 @@ public class GlueCatalogSyncClientConfig extends
HoodieConfig {
.markAdvanced()
.withDocumentation("Glue sync may fail if the Glue table exists with
partitions differing from the Hoodie table or if schema evolution is not
supported by Glue."
+ "Enabling this configuration will drop and create the table to
match the Hoodie config");
+
+ public static final ConfigProperty<String> GLUE_CATALOG_ID = ConfigProperty
+ .key(GLUE_CLIENT_PROPERTY_PREFIX + "catalogId")
+ .noDefaultValue()
+ .sinceVersion("0.15.0")
+ .markAdvanced()
+ .withDocumentation("The catalogId needs to be populated for syncing
hoodie tables in a different AWS account");
+
+ public static final ConfigProperty<String> GLUE_SYNC_DATABASE_NAME =
ConfigProperty
+ .key(GLUE_CLIENT_PROPERTY_PREFIX + "database_name")
+ .noDefaultValue()
+ .withInferFunction(cfg ->
Option.ofNullable(cfg.getString(META_SYNC_DATABASE_NAME.key()))
Review Comment:
can we add sinceVersion for this and next config as well
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/multisync/TestMultipleMetaSync.java:
##########
@@ -42,6 +43,7 @@
public class TestMultipleMetaSync extends HoodieDeltaStreamerTestBase {
+ @Disabled
Review Comment:
do we know why we had to disable this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
