cshuo commented on code in PR #13786:
URL: https://github.com/apache/hudi/pull/13786#discussion_r2306116575
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/MergeOnReadIncrementalRelationV2.scala:
##########
@@ -156,6 +156,10 @@ case class MergeOnReadIncrementalRelationV2(override val
sqlContext: SQLContext,
}
}
+ override def shouldIncludeLogFiles(): Boolean = {
+ fullTableScan
+ }
+
Review Comment:
Actually I revisited the impl of `shouldIncludeLogFiles`, but considering
limiting the scope of the fix and not introducing any side effects for the
upcomming release, I only fix it for `MergeOnReadIncrementalRelationV2`.
Strictly speaking, `MergeOnReadIncrementalRelationV1` also has such a problem,
it works well now because
`hoodie.datasource.read.incr.fallback.fulltablescan.enable` is defaultly set as
`false`, and will not fallback to full table scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
