the-other-tim-brown commented on code in PR #13424:
URL: https://github.com/apache/hudi/pull/13424#discussion_r2307485193
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java:
##########
@@ -124,10 +122,13 @@ public HiveSyncTool(Properties props, Configuration
hadoopConf, Option<HoodieTab
}
this.config = new HiveSyncConfig(props, hadoopConfForSync);
- this.databaseName = config.getStringOrDefault(META_SYNC_DATABASE_NAME);
- this.tableName = config.getStringOrDefault(META_SYNC_TABLE_NAME);
HoodieTableMetaClient metaClient = metaClientOption.orElseGet(() ->
buildMetaClient(config));
initSyncClient(config, metaClient);
+ // initSyncClient leaves syncClient as null
+ if (!Objects.isNull(this.syncClient)) {
+ this.tableName = this.syncClient.getTableName();
Review Comment:
This is for the `HIVE_IGNORE_EXCEPTIONS` case. In that case the client is
left as null. It is some existing behavior but I don't understand its utility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
