danny0405 commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2308956626
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1015,6 +1018,12 @@ String startCommit(Option<String> providedInstantTime,
String actionType, Hoodie
// unclear what instant to use, since upgrade does have a given instant.
executeUsingTxnManager(Option.empty(), () -> tryUpgrade(metaClient,
Option.empty()));
}
+ HoodieTableConfig tableConfig = metaClient.getTableConfig();
Review Comment:
in `#createTableAndValidate` we already put some validation logic there for
table versions, do you think we can move this check there to make the checks
more concentrated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
