yihua commented on code in PR #13830:
URL: https://github.com/apache/hudi/pull/13830#discussion_r2319684367
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java:
##########
@@ -1168,11 +1181,19 @@ public Stream<HoodieRecord>
generateUniqueDeleteRecordStream(String instantTime,
* @return List of hoodie records for delete
*/
public List<HoodieRecord> generateUniqueDeleteRecords(String instantTime,
Integer n) {
- return generateUniqueDeleteRecordStream(instantTime, n,
false).collect(Collectors.toList());
+ return generateUniqueDeleteRecordStream(instantTime, n, false,
System.currentTimeMillis()).collect(Collectors.toList());
Review Comment:
nit: will using `System.currentTimeMillis()` cause flakiness if the current
time is the same as before when generating the record, though it's unlikely?
Or should the test util automatically increment the timestamp for updates and
deletes based on the previous ts value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
