the-other-tim-brown commented on code in PR #13803:
URL: https://github.com/apache/hudi/pull/13803#discussion_r2323696830
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -446,9 +447,9 @@ public static boolean isLogFile(StoragePath logPath) {
}
public static boolean isLogFile(String fileName) {
- if (fileName.contains(LOG_FILE_EXTENSION)) {
+ if (fileName.startsWith(LOG_FILE_START_WITH_CHARACTER) &&
fileName.contains(LOG_FILE_EXTENSION)) {
Review Comment:
We can remove the `fileName.contains(LOG_FILE_EXTENSION)` as that is covered
as part of the regex so we don't need to scan the string twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
