yihua opened a new pull request, #13850:
URL: https://github.com/apache/hudi/pull/13850

   ### Change Logs
   
   This PR removes the error table instant time as an argument to 
`BaseErrorTableWriter#commit` and let the implementation of error table writer 
to handle error table instant time internally (like 
`BaseErrorTableWriter#upsertAndCommit` which does not take error table instant 
time as an argument and decides the error table instant time inside the 
implementation), to avoid any discrepancy.
   
   ### Impact
   
   Avoid chances of bugs around instant time handling.
   
   ### Risk level
   
   none
   
   ### Documentation Update
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to