the-other-tim-brown commented on code in PR #13830:
URL: https://github.com/apache/hudi/pull/13830#discussion_r2319948447
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -638,7 +637,7 @@ public static <R> HoodieData<HoodieRecord<R>>
tagGlobalLocationBackToRecords(
}
});
return shouldUpdatePartitionPath
- ? mergeForPartitionUpdatesIfNeeded(incomingRecordsAndLocations,
config, table)
+ ? mergeForPartitionUpdatesIfNeeded(incomingRecordsAndLocations,
config, table, readerContext, writerSchema)
Review Comment:
@nsivabalan without the merge, we don't know whether to delete the record
key from the index or to skip the delete because it has a lower ordering value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
