nsivabalan commented on code in PR #13831:
URL: https://github.com/apache/hudi/pull/13831#discussion_r2332058799
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -163,6 +163,9 @@ public HoodieStreamer(Config cfg, JavaSparkContext jssc,
FileSystem fs, Configur
cfg.recordMergeMode = mergingConfigs.getLeft();
cfg.payloadClassName = mergingConfigs.getMiddle();
cfg.recordMergeStrategyId = mergingConfigs.getRight();
+ this.properties.put(HoodieTableConfig.RECORD_MERGE_MODE.key(),
cfg.recordMergeMode.name());
+ this.properties.put(HoodieTableConfig.PAYLOAD_CLASS_NAME.key(),
cfg.payloadClassName);
+ this.properties.put(HoodieTableConfig.RECORD_MERGE_STRATEGY_ID.key(),
cfg.recordMergeStrategyId);
Review Comment:
same here as well
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -163,6 +163,9 @@ public HoodieStreamer(Config cfg, JavaSparkContext jssc,
FileSystem fs, Configur
cfg.recordMergeMode = mergingConfigs.getLeft();
cfg.payloadClassName = mergingConfigs.getMiddle();
cfg.recordMergeStrategyId = mergingConfigs.getRight();
+ this.properties.put(HoodieTableConfig.RECORD_MERGE_MODE.key(),
cfg.recordMergeMode.name());
+ this.properties.put(HoodieTableConfig.PAYLOAD_CLASS_NAME.key(),
cfg.payloadClassName);
Review Comment:
lets add only if its non null and not empty string
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java:
##########
@@ -163,6 +163,9 @@ public HoodieStreamer(Config cfg, JavaSparkContext jssc,
FileSystem fs, Configur
cfg.recordMergeMode = mergingConfigs.getLeft();
cfg.payloadClassName = mergingConfigs.getMiddle();
cfg.recordMergeStrategyId = mergingConfigs.getRight();
+ this.properties.put(HoodieTableConfig.RECORD_MERGE_MODE.key(),
cfg.recordMergeMode.name());
Review Comment:
lets add only if its non null and not empty string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
