lw309637554 commented on a change in pull request #2322:
URL: https://github.com/apache/hudi/pull/2322#discussion_r542971684
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/rollback/SparkMarkerBasedRollbackStrategy.java
##########
@@ -52,6 +52,7 @@ public SparkMarkerBasedRollbackStrategy(HoodieTable<T,
JavaRDD<HoodieRecord<T>>,
MarkerFiles markerFiles = new MarkerFiles(table,
instantToRollback.getTimestamp());
List<String> markerFilePaths = markerFiles.allMarkerFilePaths();
int parallelism = Math.max(Math.min(markerFilePaths.size(),
config.getRollbackParallelism()), 1);
+ jsc.setJobGroup(this.getClass().getSimpleName(), "Marker files
rollback");
Review comment:
> Should we clear the jobGroup after the job finish?If not, the next job
will reuse the group name.
@pengzhiwei2018 Some method to do one specific operation of hudi, may be
contain not only one spark action. it can reuse the jobGroup. In this scenario
, We don’t have to set it so detailed. Also it will be more suitable just like
@leesf mention, follow the original mechanism of Hudi.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
