yihua commented on code in PR #13711:
URL: https://github.com/apache/hudi/pull/13711#discussion_r2349941534
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/HoodieBloomIndex.java:
##########
@@ -231,12 +231,13 @@ protected List<Pair<String, BloomIndexFileInfo>>
loadColumnRangesFromMetaIndex(
List<Pair<String, BloomIndexFileInfo>> result = new
ArrayList<>(fileToColumnStatsMap.size());
for (Map.Entry<Pair<String, String>, HoodieMetadataColumnStats> entry :
fileToColumnStatsMap.entrySet()) {
+ ValueMetadata valueMetadata =
ValueMetadata.getValueMetadata(entry.getValue().getValueType());
result.add(Pair.of(entry.getKey().getLeft(),
new BloomIndexFileInfo(
partitionAndFileNameToFileId.get(entry.getKey()),
// NOTE: Here we assume that the type of the primary key field
is string
-
unwrapAvroValueWrapper(entry.getValue().getMinValue()).toString(),
- unwrapAvroValueWrapper(entry.getValue().getMaxValue()).toString()
+
valueMetadata.unwrapValue(entry.getValue().getMinValue()).toString(),
+
valueMetadata.unwrapValue(entry.getValue().getMaxValue()).toString()
Review Comment:
@jonvex also, when doing the backward compatibility testing, let's enforce
stricter validation by comparing the metadata records in column stats index in
the Metadata Table written by 0.14 and 1.1 (this PR) using the same set of
inserts/updates to make sure the storage bytes are the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
