danny0405 commented on code in PR #13860: URL: https://github.com/apache/hudi/pull/13860#discussion_r2353951074
########## hudi-common/src/main/java/org/apache/hudi/avro/JoinedGenericRecord.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.avro; + +import org.apache.hudi.common.model.HoodieRecord; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericRecord; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** + * Impl of {@link GenericRecord} to abstract meta fields and an actual data records of type GenericRecord. + */ +public class JoinedGenericRecord implements GenericRecord { + private final GenericRecord dataRecord; + private final Map<String, Object> metaFields; + private final List<String> metaFieldNames; + private final Schema schema; + + public JoinedGenericRecord(GenericRecord dataRecord, int metaFieldsSize, Schema schema) { + this.dataRecord = dataRecord; + this.metaFields = new HashMap<>(metaFieldsSize); + this.metaFieldNames = metaFieldsSize == HoodieRecord.HOODIE_META_COLUMNS.size() + ? HoodieRecord.HOODIE_META_COLUMNS + : HoodieRecord.HOODIE_META_COLUMNS_WITH_OPERATION_LIST; + this.schema = schema; + } + + @Override + public void put(String key, Object v) { + if (metaFieldNames.contains(key)) { Review Comment: we can use `HOODIE_META_COLUMNS_NAME_TO_POS` to fetch the pos of the meta fields then update the metaFields object array. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
