yihua commented on code in PR #13883:
URL: https://github.com/apache/hudi/pull/13883#discussion_r2354552701
##########
scripts/pr_compliance.py:
##########
@@ -385,33 +317,57 @@ def validate(self):
return False
self.section.error("","", "Please make sure you have filled out the
template correctly. You can find a blank template in
/.github/PULL_REQUEST_TEMPLATE.md")
return False
+
+ # Check if body contains GitHub issue link
+ def _has_github_issue_link(self):
+ # Look for GitHub issue patterns:
+ # - fixes #123, resolves #123, closes #123
+ # - fixes https://github.com/apache/hudi/issues/123
+ # - resolves https://github.com/apache/hudi/issues/123
+ # - closes https://github.com/apache/hudi/issues/123
Review Comment:
The script allows both. I updated the examples to be clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
