rahil-c commented on code in PR #13650:
URL: https://github.com/apache/hudi/pull/13650#discussion_r2357668022
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -258,18 +258,19 @@ public class HoodieWriteConfig extends HoodieConfig {
"**Note** This is being actively worked on. Please use "
+ "`hoodie.datasource.write.keygenerator.class` instead.");
- public static final ConfigProperty<Boolean> COMPLEX_KEYGEN_OLD_ENCODING =
ConfigProperty
- .key("hoodie.write.complex.keygen.old.encoding")
- .defaultValue(true)
+ // keep both configs for table version 8 and below
+ // change naming to be new and then flip default to false
+ public static final ConfigProperty<Boolean> COMPLEX_KEYGEN_NEW_ENCODING =
ConfigProperty
+ .key("hoodie.write.complex.keygen.new.encoding")
+ .defaultValue(false)
.markAdvanced()
- .sinceVersion("1.1.0")
Review Comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
