yihua commented on code in PR #13711:
URL: https://github.com/apache/hudi/pull/13711#discussion_r2359339082
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java:
##########
@@ -473,7 +481,10 @@ private <T extends Comparable<T>>
HoodieColumnRangeMetadata<T> getColumnRangeInF
.reduce(HoodieColumnRangeMetadata::merge).get();
}
- private static Comparable<?> convertToNativeJavaType(PrimitiveType
primitiveType, Comparable<?> val) {
+ private static Comparable<?> convertToNativeJavaType(PrimitiveType
primitiveType, Comparable<?> val, ValueMetadata valueMetadata) {
+ if (valueMetadata.getValueType() != ValueType.V1) {
+ return valueMetadata.standardizeJavaTypeAndPromote(val);
+ }
Review Comment:
We discussed that this is hard to achieve given the APIs we have now. So
we'll punt this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
