nsivabalan commented on code in PR #13583:
URL: https://github.com/apache/hudi/pull/13583#discussion_r2361184604
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -145,7 +145,7 @@ protected HoodieWriteHandle(HoodieWriteConfig config,
String instantTime, String
private void initSecondaryIndexStats(boolean preserveMetadata) {
// Secondary index should not be updated for clustering and compaction
// Since for clustering and compaction preserveMetadata is true, we are
checking for it before enabling secondary index update
- if (config.isSecondaryIndexEnabled() && !preserveMetadata) {
Review Comment:
SI is expected to be created via spark-sql unlike other indexes we have.
So, one has to go to spark sql to execute `drop index` for it to take
effect.
this is different from other indexes.
for FILES, RLI, COL_STATS, writer config's value in each write could dictate
whether to enable or disable the index of interest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
