yihua commented on code in PR #13515:
URL: https://github.com/apache/hudi/pull/13515#discussion_r2361599220


##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/log/block/TestHoodieDeleteBlock.java:
##########
@@ -54,6 +59,20 @@ public class TestHoodieDeleteBlock {
 
   private static Random random = new Random();
 
+  @Test
+  void validateHoodieDeleteRecordListFieldsAndOrdinals() {
+    // HoodieDeleteBlock uses IndexedRecord instead of HoodieDeleteRecordList 
as the output of
+    // reading the delete record list, due to class loading issue on the 
executor side on Spark

Review Comment:
   @the-other-tim-brown Yes, I think so.  Before this PR, `SpecificDatumReader` 
is only used in two places, `HoodieDeleteBlock` (which this PR fixes) and 
`TimelineMetadataUtils` which deserializes the commit metadata.  We should also 
check `TimelineMetadataUtils` to see if it's used on executor side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to